Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UtilityTokenAbstract: construct with and expose UUID invariants #97

Merged
merged 1 commit into from
Jan 31, 2018
Merged

UtilityTokenAbstract: construct with and expose UUID invariants #97

merged 1 commit into from
Jan 31, 2018

Conversation

jasonklein
Copy link
Contributor

@jasonklein jasonklein commented Jan 29, 2018 •
edited
Loading

✋ Merge after #100 is merged and this is rebased on develop.

For UtilityTokenAbstract:

  • includes UUID params as constructor arguments (and makes attendant changes up through to OpenSTUtility)
  • confirms that hash of UUID params matches UUID
  • stores and exposes previously unexposed attributes of the UUID: conversion rate, value chain ID, utility chain ID, and protocol address

🚨 OpenSTUtility has "a lot" of changes because the linter didn't like the order of functions (external before public, constructor before external)

Fixes #91.

@jasonklein jasonklein force-pushed the jasonbanks/gh91/pass-uuid-parameters branch 2 times, most recently from 226d892 to e030c08 Compare January 30, 2018 16:13
@jasonklein jasonklein added this to the v0.9.2 milestone Jan 30, 2018
@jasonklein jasonklein force-pushed the jasonbanks/gh91/pass-uuid-parameters branch from e030c08 to 520d4c3 Compare January 30, 2018 17:52
@jasonklein jasonklein mentioned this pull request Jan 30, 2018
Merged
benjaminbollen
benjaminbollen approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will wait for rebase

Contracts/Tests: store UUID params on and confirm UUID in contructor …
1b73235 
…for UtilityTokenAbstract; expose conversion rate. Relates to #91
@jasonklein jasonklein force-pushed the jasonbanks/gh91/pass-uuid-parameters branch from 520d4c3 to 1b73235 Compare January 31, 2018 15:08
benjaminbollen
benjaminbollen approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminbollen benjaminbollen merged commit a7104c6 into develop Jan 31, 2018
@jasonklein jasonklein mentioned this pull request Feb 5, 2018
Closed
3 tasks
@jasonklein jasonklein modified the milestones: v0.9.2, v0.9.3 Mar 27, 2018
@benjaminbollen benjaminbollen deleted the jasonbanks/gh91/pass-uuid-parameters branch June 4, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminbollen benjaminbollen benjaminbollen approved these changes

Assignees

@benjaminbollen benjaminbollen

Labels
None yet
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonklein @benjaminbollen